Fix G35 PROGMEM strings #19926
Merged
Fix G35 PROGMEM strings #19926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Speaka
added a commit
to Speaka/Marlin
that referenced
this pull request
Nov 2, 2020
vgadreau
pushed a commit
to vgadreau/Marlin
that referenced
this pull request
Dec 9, 2020
tharts
pushed a commit
to tharts/Marlin
that referenced
this pull request
Jan 6, 2021
codingcatgirl
pushed a commit
to codingcatgirl/Marlin
that referenced
this pull request
Jan 28, 2021
kpishere
pushed a commit
to kpishere/Marlin
that referenced
this pull request
Feb 19, 2021
W4tel-BiDi
pushed a commit
to W4tel-BiDi/Marlin
that referenced
this pull request
Apr 5, 2021
thinkyhead
pushed a commit
to thinkyhead/Marlin
that referenced
this pull request
Apr 28, 2021
thinkyhead
pushed a commit
to thinkyhead/Marlin
that referenced
this pull request
Apr 29, 2021
thinkyhead
pushed a commit
that referenced
this pull request
Apr 30, 2021
codingcatgirl
pushed a commit
to codingcatgirl/Marlin
that referenced
this pull request
May 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In G35
tramming_point_name[i]is stored in Progmem.SERIAL_ECHOPAIRseems to not be able to handle this on Mega2560 and 8bit in general. It points to the same address in RAM and echoes rubbish.Based on the solution linked below i tried to apply the most appropriate Serial Macro. This seems to be the best here.
This is probably not the perfect solution as I am no pro coder but I did this in style of examples at other files.
I assumed to store constant strings intended to serial in Progmem to save ram. So
SERIAL_ECHOPGMwas prefered.Benefits
Printing the tramming_point_name from PROGMEM address now how it should be.
Configurations
#define ASSISTED_TRAMMING#define DEBUG_LEVELING_FEATURERelated Issues and Sources
Based on this solution.
Bug Reports describing the same problem: #19473 #19896 propably #19555
What needs to be done
I can only test on my 8bit System.
This needs to be tested on other Systems especially other architectures. I don't know how this will work on 32bit.